Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] 3.3: Factor out ETH Flow from core services #20

Open
fleupold opened this issue Oct 18, 2023 · 0 comments
Open

[Epic] 3.3: Factor out ETH Flow from core services #20

fleupold opened this issue Oct 18, 2023 · 0 comments
Assignees
Labels
E:3.3 Factor out ETHFlow See https://github.com/cowprotocol/pm/issues/20 for details epic Tracks a yearly team epic (only for cowprotocol/pm repo)

Comments

@fleupold
Copy link
Contributor

Epic label: E:3.3 Factor out ETHFlow
Planned start date: 01.11.2023
Due date: 31.12.2023

Summary

ETH Flow was developed under time pressure before basic protocol features such as pre/post interactions and generalized ERC1271 support had been implemented for the core services.

As a consequence we have create a lot of logic, special code paths and edge cases in the core services repository in order to make ETH Flow work.
With the development of hooks and initiatives like TWAP it has become apparent that ETH Flow should be treated not as a core protocol feature, but instead be part of the periphery and use protocol primitives such as hooks and ERC1271 orders to achieve the same user outcome.

This EPIC captures refactoring the ETH flow logic into a periphery service (similar to or even part of the watch-tower) so that the core services no longer have to special case these orders.

Acceptance Criteria

  • Core services are completely agnostic to ETH flow orders.
  • Native ETH flow orders are placed using the standard public API
  • Users still have the same user experience in the App and explorer

Tasks

@fleupold fleupold added the epic Tracks a yearly team epic (only for cowprotocol/pm repo) label Oct 18, 2023
@fleupold fleupold added this to the Complexity Reduction milestone Oct 18, 2023
@fleupold fleupold added the E:3.3 Factor out ETHFlow See https://github.com/cowprotocol/pm/issues/20 for details label Oct 18, 2023
@mfw78 mfw78 changed the title [Epic] 3.3 Factor out ETH Flow from core services [Epic] 3.3: Factor out ETH Flow from core services Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:3.3 Factor out ETHFlow See https://github.com/cowprotocol/pm/issues/20 for details epic Tracks a yearly team epic (only for cowprotocol/pm repo)
Projects
None yet
Development

No branches or pull requests

2 participants