Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] 4.1: Quote adjustment for solvers #26

Open
3 tasks
olgafetisova opened this issue Oct 27, 2023 · 1 comment
Open
3 tasks

[Epic] 4.1: Quote adjustment for solvers #26

olgafetisova opened this issue Oct 27, 2023 · 1 comment
Labels
E:4.1 Quote adjustment for solvers See https://github.com/cowprotocol/pm/issues/26 for details epic Tracks a yearly team epic (only for cowprotocol/pm repo)
Milestone
Sustainability

Comments

@olgafetisova
Copy link

olgafetisova commented Oct 27, 2023 •
edited
Loading

Epic label: E:4.1 Quote adjustment for solvers
Planned start date: 01/12/2023
Due date: 21/12/2023

Summary

Quote adjustment is necessary for solvers to be able to determine the quoted price at the time of the order (market order or out-of-market order) and decide whether they need to apply additional calculations on top of that.
Additionally, the task requires storing this data for analytics purposes and the frontend team.

Tasks

  • Store quotes for all orders (currently, we don’t have quotes for limit orders, which may - if placed below market, e.g. after the Milkman refactoring - be immediately filled and otherwise cause a high fee)
  • Forward the quoted amount from the autopilot to the co-located drivers
  • Store quotes for analytics purposes.
@olgafetisova olgafetisova added the epic Tracks a yearly team epic (only for cowprotocol/pm repo) label Oct 27, 2023
@olgafetisova olgafetisova added this to the Sustainability milestone Oct 27, 2023
@mfw78 mfw78 changed the title [Epic] Quote adjustment for solvers [Epic] 4.1 Quote adjustment for solvers Oct 30, 2023
@mfw78 mfw78 added the E:4.1 Quote adjustment for solvers See https://github.com/cowprotocol/pm/issues/26 for details label Oct 30, 2023
@sunce86
Copy link

sunce86 commented Nov 24, 2023

Store quotes for analytics purposes.

What does this mean exactly? Quotes will be stored in database, is that enough? Is the backend supposed to make stored quotes available via API?

@mfw78 mfw78 changed the title [Epic] 4.1 Quote adjustment for solvers [Epic] 4.1: Quote adjustment for solvers Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:4.1 Quote adjustment for solvers See https://github.com/cowprotocol/pm/issues/26 for details epic Tracks a yearly team epic (only for cowprotocol/pm repo)
Projects
None yet
Milestone
Sustainability
Development

No branches or pull requests
3 participants
@sunce86 @olgafetisova @mfw78