Improved errors conversions

cowprotocol · Dec 11, 2024 · ebd3e3b · ebd3e3b
1 parent c61f4bc
commit ebd3e3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/crates/orderbook/src/database/orders.rs b/crates/orderbook/src/database/orders.rs
@@ -104,11 +104,11 @@ impl OrderWithQuote {
                         buy_amount: u256_to_big_decimal(&quote.buy_amount),
                         solver: ByteArray(quote.data.solver.0),
                         verified: quote.data.verified,
-                        metadata: quote.data.metadata.try_into().map_err(
-                            |e: serde_json::Error| {
-                                AddOrderError::MetadataSerializationFailed(e.into())
-                            },
-                        )?,
+                        metadata: quote
+                            .data
+                            .metadata
+                            .try_into()
+                            .map_err(AddOrderError::MetadataSerializationFailed)?,
                     })
                 })
                 .transpose()?,

diff --git a/crates/orderbook/src/orderbook.rs b/crates/orderbook/src/orderbook.rs
@@ -142,7 +142,7 @@ pub enum AddOrderError {
         existing: String,
     },
     #[error("quote metadata failed to serialize as json, error: {0}")]
-    MetadataSerializationFailed(#[source] anyhow::Error),
+    MetadataSerializationFailed(serde_json::Error),
 }
 
 impl AddOrderError {
@@ -164,7 +164,7 @@ impl AddOrderError {
                 },
             },
             InsertionError::MetadataSerializationFailed(err) => {
-                AddOrderError::MetadataSerializationFailed(err.into())
+                AddOrderError::MetadataSerializationFailed(err)
             }
         }
     }