-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump staging auction_id to avoid clashing of auction ids in different environments #2848
Comments
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
I just made a temporary fix that works if auctions ids are far away one from another (staging vs prod): #3053 So I think we still want to do this as a long term solution. |
Background
Staging is frontrunning the production environment by ~270 days. Meaning, when auction with ID = X appears on staging, after 270 days production will also create an auction with ID = X. This is problematic for components that process both staging and production data that appears onchain (for example OnSettlementEventUpdater checks for settlements that are sent to the same settlement contract from staging and production).
This is completely unnecessary complication that leads to bugs / complicated code without any need.
Suggestion is to bump staging auction id by some big number so that production will "never" catch it. Since auction_id is saved to db as i64, suggestion is to bump current staging auction id by i64::MAX / 2.
This can be safely done in a few steps:
Acceptance criteria
Once finished, staging auction_ids are bumped.
The text was updated successfully, but these errors were encountered: