Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Stop using string for solution_id #3072

Open
sunce86 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3154
Open

chore: Stop using string for solution_id #3072

sunce86 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3154

Comments

@sunce86
Copy link
Contributor

sunce86 commented Oct 18, 2024

Background

A cleanup task that should follow up after #3071, once solvers switched to using integers.

/reveal and /settle calls should be adjusted to use integers and /solve deserialization cleanup up.

sunce86 added a commit that referenced this issue Oct 18, 2024
# Description
Related to #3064

This PR enables driver to send either string or integer for
`solution_id`.

This PR marks the start of transition period. Once the PR is merged,
external solvers will be asked to:
1. Start sending `solution_id` as integer in `/solve` response.
2. Implement receiving either string or integer for `solution_id` on
`/reveal` and on `/settle`.

Once done, backend will have a [follow
up](#3072) where we will
definitely switch to using integers in all three endpoints and
#3064 will be fixed.

## How to test
Manually checked that both versions are properly
serialized/deserialized.

<!--
## Related Issues

Fixes #
-->
@sunce86 sunce86 linked a pull request Dec 10, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant