Remove "latest_settlement_block" from API

[sunce86]

Description

Recently we introduced a new database table to store all auction objects -> competition_auctions table. Note that this table does not contain field latest_settlement_block. The reason is that this field is actually deductible from other data in the database -> it's even deductible from blockchain. For a given block X, you can always know what is the latest block before block X where the last settlement was settled.

Moreover, latest_settlement_block is now only used internally in solvable orders cache component of autopilot, so it's not actually a core autopilot information.

This change opens the door to unify auction and competition_auctions table with final goal of removing auction table completely. Removes tech debt.

Changes

• Remove latest_settlement_block field from api and autopilot

How to test

All tests passing.
If you are worried about a transition period, removing a field shouldn't be problematic for deserializing old object containing latest_settlement_block.

The only concern is that solvers needs to adjust their deserialize logic so it doesn't break. Will be notified in advance once approvals are collected.

[github-actions]

Reminder: Please consider backward compatibility when modifying the API specification.
If breaking changes are unavoidable, ensure:

• You explicitly pointed out breaking changes.
• You communicate the changes to affected teams.
• You provide proper versioning and migration mechanisms.

---

Caused by:

• crates/orderbook/openapi.yml

[m-lord-renkse]

What would happen when calling load_most_recent() or fetch() from the persistence auction? wouldn't it crash because it will have an unexpected field? 🤔

[sunce86]

What would happen when calling load_most_recent() or fetch() from the persistence auction? wouldn't it crash because it will have an unexpected field? 🤔

If you refer to this line, this would pass.

[m-lord-renkse]

Approved assuming this will be communicated to solvers on time.

[squadgazzz]

LG