[EASY] Parallelize post processing in run loop #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
added
the
E:6.1 One auction per block
m-lord-renkse
approved these changes
Sep 25, 2024
sunce86
approved these changes
Sep 25, 2024
MartinquaXD
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we briefly stored all fee policies for a given auction in the post processing it increased the time for that critical section quite significantly.
That change was removed since then but the learning still stands that these operations might as well happen in parallel.
Changes
Run the 3 DB inserts futures of the run loop post processing in parallel.
How to test
It's a very small change so the e2e tests should be sufficient