Reveal and settle to receive integer solution id #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
approved these changes
Dec 9, 2024
| @@ -15,3 +15,34 @@ pub(super) use { | |||
| settle::settle, | |||
| solve::{solve, AuctionError}, | |||
| }; | |||
|
|
|||
| pub fn deserialize_solution_id<'de, D>(deserializer: D) -> Result<u64, D::Error> | |||
There was a problem hiding this comment.
This is duplicated code, couldn't we move it to some utils crate? 🤔
There was a problem hiding this comment.
Not worth the effort since it will be removed again.
MartinquaXD
approved these changes
Dec 10, 2024
| @@ -15,3 +15,34 @@ pub(super) use { | |||
| settle::settle, | |||
| solve::{solve, AuctionError}, | |||
| }; | |||
|
|
|||
| pub fn deserialize_solution_id<'de, D>(deserializer: D) -> Result<u64, D::Error> | |||
There was a problem hiding this comment.
Suggested change
| pub fn deserialize_solution_id<'de, D>(deserializer: D) -> Result<u64, D::Error> | |
| pub(crate) fn deserialize_solution_id<'de, D>(deserializer: D) -> Result<u64, D::Error> |
So the compiler helps us to remember cleaning up this function when we stop using it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow up for #3071
This PR allows reference driver to receive both integer and strings for solution id, on
/revealand/settleendpoints. Note how this PR implements task 2 from the linked pull request. This is done in this PR as a separate step to give time to colocated solvers using reference driver to update on time.If we were to just switch to using integer, colocated drivers would incur downtime.
Next step is final step to use integer ONLY in both autopilot and driver, once we made sure all colocated solvers updated their driver.
Changes
/revealand/settleHow to test
The code is copy paste of already tested code.