[DEMO — Do not merge] Use Split-Delegation Strategy from Gnosis Guild

[samepant]

Description

This PR demonstrates the changes required to leverage the Split-Delegation system that we've built at Gnosis Guild. This system uses a new delegation contract, an indexing service, and an api for making and tracking delegations.

This new delegation system supports:

• split delegations (i can delegate 50% of my vote weight to someone and 50% to someone else)
• transitive delegations (i delegate to A, A delegates to B, my delegation flows to B)
• expiring delegations

All the code for the Split-Delegation system can be viewed here: https://github.com/gnosisguild/split-delegation

We've also made changes to the Snapshot frontend that allow this system to be used natively in the snapshot app, but are awaiting PR review. A demo of these changes can be viewed here: https://snapshot-ochre.vercel.app/#/cow.ggtest.eth/delegates

Changes

In order to use this strategy, existing strategies used to get the voting scores should be moved to the strategies param on the Split-Delegation strategy. This makes them sub-strategies, and the split-delegation system will add up the scores from the sub-strategies and then will apply the vote weight calculations to compute the final voting power of any address.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[samepant]

I have read the CLA Document and I hereby sign the CLA

[cmagan]

Thanks @samepant, this is very useful for our planned CIP launching a delegation campaign!

[mfw78]

Looks neat - but how can the results of the poll be independently verified?

[samepant]

Looks neat - but how can the results of the poll be independently verified?

Hey @mfw78 ! Curious what you mean by poll? The code is open source and is running through snapshot's system, so the trust assumptions are similar to the current setup.

[samepant]

Just pushed another commit, after talking with Snapshot people, we've decided it makes sense to add split-delegation to the top level space settings as well as in the strategy settings. This helps Snapshot's frontend decide which delegation UI components to use on its delegation dashboard.

[wa0x6e]

Hey, I'm wan from the snapshot team.

I just took a look at the settings.json file, and it technically looks good.

• json file is valid
• "erc20-balance-of-delegation" strategies has been removed (since now supported by the split-delegation natively now)
• delegation portal settings are correct

I plugged those same settings into a test space, and it's working. Did not test the delegation side though, as I don't have cow.

The only point I am not sure is the

"totalSupply": 1284949976,

Can you confirm this is your coin total supply ?

[cmagan]

@wa0x6e thanks for reviewing!
Can you please share the test space you've deployed?
I also created a test space https://snapshot.org/#/cowtesting.eth
Not sure why it allows me to create proposal from wallets which doesn't have the min 10k COW tokens?
On the main space interface I can't seem to find the delegation dashboard, is there any additional setting for adding it or should users access it from a different link?

[cmagan]

Hey, I'm wan from the snapshot team.

I just took a look at the settings.json file, and it technically looks good.

• json file is valid
• "erc20-balance-of-delegation" strategies has been removed (since now supported by the split-delegation natively now)
• delegation portal settings are correct

I plugged those same settings into a test space, and it's working. Did not test the delegation side though, as I don't have cow.

The only point I am not sure is the

"totalSupply": 1284949976,

Can you confirm this is your coin total supply ?

The total COW max supply is 1b tokens: https://etherscan.io/token/0xdef1ca1fb7fbcdc777520aa7f396b4e015f497ab
but about 50% is kept in the COW DAO treasury unallocated.
What number should be there?

[wa0x6e]

@wa0x6e thanks for reviewing! Can you please share the test space you've deployed? I also created a test space https://snapshot.org/#/cowtesting.eth Not sure why it allows me to create proposal from wallets which doesn't have the min 10k COW tokens? On the main space interface I can't seem to find the delegation dashboard, is there any additional setting for adding it or should users access it from a different link?

To enable the delegation dashboard, you have to go to your space settings, then delegation.

In the form, you have to select "Split delegation", then enter your api and contract address

Then, go to the strategies section, and add the "Split delegation" strategy

[cmagan]

The only way for CoW DAO to update its space settings is though updating the settings json file which we're discussing ATM...
Would be lovely if you can help us add this change (delegation dashboard) to the PR 🙏

[wa0x6e]

Hey, I'm wan from the snapshot team.
I just took a look at the settings.json file, and it technically looks good.

• json file is valid
• "erc20-balance-of-delegation" strategies has been removed (since now supported by the split-delegation natively now)
• delegation portal settings are correct

I plugged those same settings into a test space, and it's working. Did not test the delegation side though, as I don't have cow.
The only point I am not sure is the

"totalSupply": 1284949976,

Can you confirm this is your coin total supply ?

The total COW max supply is 1b tokens: https://etherscan.io/token/0xdef1ca1fb7fbcdc777520aa7f396b4e015f497ab but about 50% is kept in the COW DAO treasury unallocated. What number should be there?

I believe it's 1,000,000,000 (from etherscan), maybe @samepant can confirm. Where did you get that 1284949976 number from ?

[samepant]

@cmagan delegation settings are here, this should enable the portal on the space

[samepant]

I believe it's 1,000,000,000 (from etherscan), maybe @samepant can confirm. Where did you get that 1284949976 number from ?
^^ this can be ignored, it was a dummy value based on the previous strategies.

i think it should be the current circulating supply of tokens, not the total supply, since those are the only ones that can be used to vote.

[mfw78]

What API is required for this? Concretely what is required to make this work?

[cmagan]

What API is required for this? Concretely what is required to make this work?

@mfw78 the API that is required is open source and available here.

The api going down would interrupt vote calculation — but the vote could be recalculated once it's back up.
If it's a concern, the api backend is open source so anyone can run their own version of it

[mfw78]

Where is the settings.json documented for the delegation portal etc? Given that we set the settings.json via IPFS, having a UI guided setup is not appropriate / sufficient. It is much better that we have a source of truth (documentation) that we can draw from with which to verify / validate settings.

[wa0x6e]

Where is the settings.json documented for the delegation portal etc? Given that we set the settings.json via IPFS, having a UI guided setup is not appropriate / sufficient. It is much better that we have a source of truth (documentation) that we can draw from with which to verify / validate settings.

This delegation type is largely handled by the guys at Gnosis (https://github.com/gnosisguild/split-delegation), snapshot is only using their API to display the delegates, and their contract to handle the delegation.

We don't have an updated documentation yet, but the settings is only asking 2 things: a contract address, and API url, which are both provided by gnosis at the moment.

[mfw78]

Concretely, there should be documentation cited for the changes, and a test methodology established (sure, it can be on some test site - but there should be written a solid methodology from which reviewers can establish the basis for the PR).

Additionally, I'm obviously not going to approve something that is "DEMO - Do not merge". If this is to be pushed to prod, can we please have the PR updated with a step-by-step testing methodology and appropriate PR description/title changes 🙏