Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Leniently retry on specific unknown revert conditions (e.g., math over/underflow) #144

Open
fedgiac opened this issue Feb 9, 2024 · 0 comments
Assignees

Comments

@fedgiac
Copy link
Contributor

fedgiac commented Feb 9, 2024

Background

Suppose that the watchtower tries to poll a new order from getTradeableOrder() and this call reverts.
If the call reverts and the revert error isn't recognized, then the watchtower stops indexing further CoW Protocol orders from the same conditional order.
This may be undesirable for certain revert conditions, main example being reverts because of overflow/underflow/division by zero.

Details

This applies to the legacy polling method.

Acceptance criteria

A possible solution would be implementing a back-off mechanism for a list of known revert conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants