New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move error handling to SDK #17

Open

anxolin opened this issue Aug 24, 2023 · 1 comment

Labels

Contributor

anxolin commented Aug 24, 2023 •

edited

Loading

@mfw78 did some nice error handlings in #15

Now the polling happen in the SDK. See:

We might want to move some of the legacy logic to the SDK.

Here is a pointer in the code. The legacy is executed if the Factory can't create an order. This happens if the handler is unknown:
https://github.com/cowprotocol/tenderly-watch-tower/pull/16/files#diff-8e2dc90f4a6ebdf01f8603707f37f7794972fdf1827102bfce89497804f72837R157

We will need to decide if we want to index unknown handlers. If so, we can have in the SDK also some generic logic for the polling.

mfw78 added the enhancement label

Contributor Author

anxolin commented Oct 3, 2023

Related #64 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment