You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
I like the idea of the project, and wanna join to make a little contribution. before that, I need to understand the code, so I start to read the code.
I found that the coding style of deeply nested if statement is kinda hard to read. I think early exit is much more readable.
Would you consider to make a switch of the style? https://en.wikibooks.org/wiki/Computer_Programming/Coding_Style/Minimize_nesting
The text was updated successfully, but these errors were encountered:
Thank you for your message. It's great you want to contribute and any help would be welcome.
About nesting code style, it adds a lot of readability by adding meaningful blocks. So we won't change it. The only things that could be used to simplifiy is the return callback(err); at the beginning of each callback functions.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I like the idea of the project, and wanna join to make a little contribution. before that, I need to understand the code, so I start to read the code.
I found that the coding style of deeply nested if statement is kinda hard to read. I think early exit is much more readable.
Would you consider to make a switch of the style?
https://en.wikibooks.org/wiki/Computer_Programming/Coding_Style/Minimize_nesting
The text was updated successfully, but these errors were encountered: