Skip to content
This repository was archived by the owner on Feb 9, 2018. It is now read-only.

Add feature to change the volume with scroll button over the volume volume-bar #116

Open
fabienmorin opened this issue Nov 9, 2016 · 5 comments

Comments

@fabienmorin
Copy link

fabienmorin commented Nov 9, 2016

many other player do that, it's user friendly and would be nice to have it too in cozy-music

@fabienmorin fabienmorin changed the title it would be nice to change the volume with scroll button over the volume volume-bar Add feature to change the volume with scroll button over the volume volume-bar Nov 9, 2016
@jsilvestre
Copy link

Great idea! Thank you for suggesting!

@flyingrub
Copy link

#121 fixed

@fabienmorin
Copy link
Author

fabienmorin commented Nov 18, 2016

Hi, thanks for the fix. It works quite well on chrome for me but on FF, it is just lowering the volume whatever the sense I roll the wheel. I found that interesting documentation by looking for this problem, may be that could helps.

For an easier use, I would propose to extend this behaviour not only to the volume-bar div block but on the whole controls-extended div block. Then it is no required to be exactly on the small volume bar to change the volume level, see #122.

@jsilvestre
Copy link

jsilvestre commented Dec 3, 2016

Oh! I just realized you did this PR, thank you very much! I had the same suggestion and asked @ysa000 to fix it (see #128 :p)

@m4dz and @ysa000, can I let you deal with this please?

@fabienmorin
Copy link
Author

I see. Anyway, my code proposal was not working.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants