fix: Use find method where args are for find #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to check if there is some options
related to _find. If yes, then we should use
this route instead of {normal|all}_docs
Crash--
requested review from
trollepierre,
Merkur39 and
paultranvan
as code owners
2 tasks
paultranvan
reviewed
Aug 17, 2022
| const hasFindOptions = queryDefinition => { | ||
| const { selector, partialFilter, sort, fields } = queryDefinition | ||
| if (selector || partialFilter || sort || fields) return true | ||
| return false |
There was a problem hiding this comment.
don't you prefer return selector || partialFilter || sort || fields ?
There was a problem hiding this comment.
I do not have any pref. At first, this method was more complicated than just returning the fields. Since I wrote it that way, I will commit that way. Maybe next time you'll change it :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to check if there is some options
related to _find. If yes, then we should use
this route instead of {normal|all}_docs
Fix #1216