fix(search): don't fetch cozy-notes url until Suggestion is clicked

waiting for cozy/cozy-bar#770

src/drive/web/modules/services/components/SuggestionProvider.jsx

@@ -39,7 +39,7 @@ class SuggestionProvider extends React.Component {
           title: result.name,
           subtitle: result.path,
           term: result.name,
-          onSelect: 'open:' + result.url,
+          onSelect: result.onSelect || 'open:' + result.url,
           icon: result.icon
         }))
       },
@@ -64,11 +64,8 @@ class SuggestionProvider extends React.Component {
 
     const normalizedFilesPrevious = files.filter(notOrphans)
 
-    const normalizedFiles = await Promise.all(
-      normalizedFilesPrevious.map(
-        async file =>
-          await makeNormalizedFile(client, folders, file, getIconUrl)
-      )
+    const normalizedFiles = normalizedFilesPrevious.map(file =>
+      makeNormalizedFile(client, folders, file, getIconUrl)
     )
 
     this.fuzzyPathSearch = new FuzzyPathSearch(normalizedFiles)

src/drive/web/modules/services/components/helpers.js

@@ -2,20 +2,28 @@ import { models } from 'cozy-client'
 
 export const TYPE_DIRECTORY = 'directory'
 
-export const makeNormalizedFile = async (client, folders, file, getIconUrl) => {
+/**
+ *
+ * @param client
+ * @param folders
+ * @param file
+ * @param getIconUrl
+ * @returns {{path: (*|string), name, icon, id, url: string, onSelect: (function(): Promise<string>)}}
+ */
+export const makeNormalizedFile = (client, folders, file, getIconUrl) => {
   const isDir = file.type === TYPE_DIRECTORY
   const dirId = isDir ? file._id : file.dir_id
   const urlToFolder = `${window.location.origin}/#/folder/${dirId}`
 
-  let path, url
+  let path, url, onSelect
   if (isDir) {
     path = file.path
     url = urlToFolder
   } else {
     const parentDir = folders.find(folder => folder._id === file.dir_id)
     path = parentDir && parentDir.path ? parentDir.path : ''
     if (models.file.isNote(file)) {
-      url = await models.note.fetchURL(client, file)
+      onSelect = () => models.note.fetchURL(client, file)
     } else {
       url = `${urlToFolder}/file/${file._id}`
     }
@@ -26,6 +34,7 @@ export const makeNormalizedFile = async (client, folders, file, getIconUrl) => {
     name: file.name,
     path,
     url,
+    onSelect,
     icon: getIconUrl(file)
   }
 }