Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #85

Open
xarthurx opened this issue Sep 15, 2022 · 7 comments
Open

Windows support #85

xarthurx opened this issue Sep 15, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@xarthurx
Copy link

I'm trying to use the action to push a project build by msbuild using .net framework on Windows host.
However, when trying to push it to another repo, I got:
image

Is there any possibility to support Windows at some point?

@xarthurx xarthurx added the bug Something isn't working label Sep 15, 2022
@cpina
Copy link
Owner

cpina commented Sep 15, 2022

For what I'm reading (in other actions issues) the action should be written in JavaScript in order to work on Windows or MacOS. If you are working on Windows and GitHub... do you know if this is correct? Thanks!

@xarthurx
Copy link
Author

For what I'm reading (in other actions issues) the action should be written in JavaScript in order to work on Windows or MacOS. If you are working on Windows and GitHub... do you know if this is correct? Thanks!

I investigated a bit and found that it is docker that Windows cannot support.

I forked your action and modified to the "composite" version, which works on Windows (the VM can somehow run bash scripts)

https://github.com/xarthurx/github-action-push-to-another-repository-win

If you want, I can submit a PR. Otherwise, I'll keep it for my own use.

@cpina
Copy link
Owner

cpina commented Sep 15, 2022

(Related #36)

@cpina
Copy link
Owner

cpina commented Sep 15, 2022

I forked your action and modified to the "composite" version, which works on Windows (the VM can somehow run bash scripts)

Oops, to try helping another user (#78 ) I've done exactly the same (composite experimental version) in https://github.com/cpina/github-action-push-to-another-repository/tree/debug-78 (but working on Ubuntu/Debian because installing the openssh-client and git).

In your fork: I like that you used variables instead of arguments for entrypoint.

No need to create a MR for now but thanks for offering.

Next weeks I am quite busy but I will think about keeping a branch with the composite version and documenting it (it might help users with a hosted GitHub Action runner that cannot create containers, Windows users and Mac). I might ping you to give it a try at some point when I've documented it if you don't mind as a quick check.

@xarthurx
Copy link
Author

In your fork: I like that you used variables instead of arguments for entrypoint.

Because in "composite" mode, you cannot pass an argument...

Next weeks I am quite busy but I will think about keeping a branch with the composite version and documenting it (it might help users with a hosted GitHub Action runner that cannot create containers, Windows users and Mac). I might ping you to give it a try at some point when I've documented it if you don't mind as a quick check.

Sure.

@cpina
Copy link
Owner

cpina commented Sep 16, 2022

Because in "composite" mode, you cannot pass an argument...

I did it: https://github.com/cpina/github-action-push-to-another-repository/blob/debug-78/action.yml#L57

It has the advantage that I didn't need to change how entrypoint.sh receives the options. But I could make entrypoint.sh to receive the options via environment variables or arguments.

I will close this ticket when I've documented the current state of the action regarding Windows (probably the next days).

@xarthurx
Copy link
Author

Because in "composite" mode, you cannot pass an argument...

I did it: https://github.com/cpina/github-action-push-to-another-repository/blob/debug-78/action.yml#L57

It has the advantage that I didn't need to change how entrypoint.sh receives the options. But I could make entrypoint.sh to receive the options via environment variables or arguments.

I will close this ticket when I've documented the current state of the action regarding Windows (probably the next days).

Ah, yeah, you can pass it as cmd argument. That's smart.
I meant the way that docker did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants