Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol類をローカルで保持する #27

Closed
saki7 opened this issue Nov 12, 2017 · 1 comment
Closed

Symbol類をローカルで保持する #27

saki7 opened this issue Nov 12, 2017 · 1 comment
Labels
enhancement help wanted

Comments

@saki7
Copy link
Contributor

saki7 commented Nov 12, 2017

今のcrsearch.js内では、定数を全体的に Symbol.for('名前') に依存している。これはどこで書いても重複しないという利点があるものの、グローバルな定数になってしまうため、同等なことを「Databaseクラスのインスタンスのユニーク性（crsearch.jsonの仕様を参照）」の範囲で解決できるように、Databaseクラスの内部で定数のファクトリを持つ実装に変更する。

refs: cpprefjp/site#477
@saki7 saki7 closed this as completed in ec35b6c Nov 12, 2017
@saki7
Copy link
Contributor Author

saki7 commented Nov 12, 2017

定数のファクトリは流石にヤバすぎると思ったので普通のstringにしました、WeakMapのキーに出来ないという問題があるけど……

saki7 added a commit to cpprefjp/kunai that referenced this issue Nov 12, 2017
@saki7
Symbol類をstringに変更 ref: cpprefjp/crsearch#27
549af7a 
cpprefjp/site#477 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saki7