Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCL v7 #18

Open
JSRankins opened this issue Aug 27, 2021 · 2 comments
Open

GCL v7 #18

JSRankins opened this issue Aug 27, 2021 · 2 comments

Comments

@JSRankins
Copy link

JSRankins commented Aug 27, 2021 •
edited
Loading

https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/blob/master/Source/Libraries/MATGlobalCommonFunctions-7.0.000.cql

This is more of a stylistic question, but should ToDateInterval function be renamed to reflect that this function provides a closed interval?
@brynrhodes
Copy link
Member

Apologies, I missed this notification so didn't get a chance to discuss it during the review. I don't feel too strongly about it, but I do have a preference for the shorter name.

@JSRankins
Copy link
Author

Completely understand. Maybe something that could be added to a comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brynrhodes @JSRankins