Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala.js source maps are pointing to unpublished generated sources #519

Open
raquo opened this issue Nov 5, 2024 · 1 comment
Open

Scala.js source maps are pointing to unpublished generated sources #519

raquo opened this issue Nov 5, 2024 · 1 comment

Comments

@raquo
Copy link

raquo commented Nov 5, 2024

Hello,

The Scala.js source maps should point to the corresponding file on raw.githubusercontent.com containing the corresponding file content.

For example, the source map url for ZoneRulesProvider.scala should* point to https://raw.githubusercontent.com/cquiroz/scala-java-time/v2.6.0/core/shared/src/main/scala/org/threeten/bp/zone/ZoneRulesProvider.scala, however currently the published source maps for this file are pointing to https://raw.githubusercontent.com/cquiroz/scala-java-time/v2.6.0/core/js/target/scala-3.3.3/src_managed/main/org/threeten/bp/zone/ZoneRulesProvider.scala which does not exist.

* Assuming that the files are copied into target without modification. If there are source modifications during that copy, then the issue becomes more complicated.

This source mapping feature was first raised in #25 and fully implemented in #32. It's likely that moving to sbt-typelevel in #418 broke this, as that is when the code from #32 was removed.

ETA: As for how to test the correctness of the paths – the sjsir files in the published artifact are binary, but contain these paths as plain strings, so you can view them e.g. in IntelliJ under "external libraries" in the project / file tree, when loading the library from another intellij project. IDE may need a restart / reload when updating the publishLocal-ed version to see the changes.

@cquiroz
Copy link
Owner

cquiroz commented Nov 5, 2024

I'm sorry too hear that, I'd be happy too accept a PR if you find a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants