-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor JSON dump format issue for long GPS logs #36
Comments
Here's a few options that I can think about:
All of these changes introduce potentially consumer-breaking changes, so if we're worried about that, we can keep a command-line option to restore previous behavior. Or not, and let people who need the old behavior back sync to an earlier commit and open an issue. My proposal for now is option 1 with no command-line option to control it. It's the simplest given what I know about user need (i.e. not much, only my speculation), and if people manifest themselves as needing something like option 2, 3 or 4, we can implement it then. Alternatively, option 2 is simple enough for me to take on, but I'd just worry a bit about adding code that nobody really needs, which makes it difficult to assess correctness. Thoughts? |
I am leaning towards option 1. As far as I can see not much "need" for all that header data has materialized so far, so you're free to pick and choose what works best for you. It'll be relatively easy to add it again should we learn otherwise. |
The LOCUS GPS log can contain multiple 4kB blocks, but this was unknown when the JSON log dump format was conceived. Consequently, fixing the log truncation bug in #35 resulted in a minor regression in that area, specifically that dumps of GPS logs with many entries spanning multiple blocks do not fully represent the binary in-memory format any longer.
At the moment, no workflows in the code rely on this requirement, so this issue is merely documenting that the format's bijectivity promise is broken for the time being.
The text was updated successfully, but these errors were encountered: