Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this repo dead? #38

Open
andig opened this issue Jun 14, 2019 · 9 comments
Open

Is this repo dead? #38

andig opened this issue Jun 14, 2019 · 9 comments

Comments

@andig
Copy link
Contributor

andig commented Jun 14, 2019

ping @crabmusket @jonseymour I realize the last commit to this repo is already two years old. The codebase looks great gut is in some parts beyond my skill or my modbus/sunspec expertise.

Are these issues (and one PR) something you'd still consider looking into?

@andig andig changed the title Repo dead? Is this repo dead? Jun 14, 2019
@crabmusket
Copy link
Owner

crabmusket commented Jun 27, 2019

Hey @andig sorry for the slow reply! I don't often check my github notifications. I can't speak for @jonseymour but as far as I'm concerned, yes, this repo is pretty much dead. Sorry! I was looking into sunspec for a project years ago but have since moved on. If you want to use it I'd recommend a hard fork (not a github fork, just create your own repo starting from this point and rewrite all module paths).

What are you trying to implement?

@andig
Copy link
Contributor Author

andig commented Jun 28, 2019

Thank you @crabmusket for replying. I‘ve contributed to https://github.com/gonium/gosdm630 for some time and have since moved to https://github.com/volkszaehler/mbmd which is part of a German smart meter enthusiasts project. Goal for using gosunspec is to provide a convenient way to easily integrate supported modbus meters, inverters etc into home automation and smart metering.

I would consider forking gosunspec into the volkszaehler organization for sake of visibility but would much rather contribute here as a big part of the codebase is beyond my skills and interest, e.g. the entire xml-related stuff. So it would only be a half-maintained fork anyway.

I could do some work here in this repo (see prs, update models) but that would require access and support in terms of reviews/ 4eyes principle. Could that work for you or @jonseymour ?

@crabmusket
Copy link
Owner

crabmusket commented Jul 4, 2019

I think I would be more comfortable if you're in your own repo. I will add a note to this repo stating the current status. My reason is that I'm no longer familiar enough with the code or the problem domain to provide any sensible feedback, or to have any percieved ownership of the code itself. Better to have a half-maintained fork than a not-at-all-maintained trunk, I think. I'm sorry!

EDIT: I've emailed Jon in case he also isn't getting notifications. Will see what he reckons :)

@crabmusket crabmusket pinned this issue Jul 4, 2019
@andig
Copy link
Contributor Author

andig commented Jul 6, 2019

I think I would be more comfortable if you're in your own repo.

I understand. For the time being I've added a rollup branch at andig/gosunspec with updated import path.

EDIT: I've emailed Jon in case he also isn't getting notifications. Will see what he reckons :)

Looking forward to his feedback

@jonseymour
Copy link
Collaborator

Hey @andig. I haven't been doing much work with sunspec related tech lately and sorry for not getting back to you earlier.

I am happy to go through the issues and PRs you have raised over the next week or two. I don't have a strong view about future ownership of the codebase. I'd be happy to host it under either my personal or company github account but I am also happy for you to own it, given your current active interest in it.

@andig
Copy link
Contributor Author

andig commented Jul 19, 2019

I am happy to go through the issues and PRs you have raised over the next week or two. I don't have a strong view about future ownership of the codebase.

Great, thanks for taking an interest to both of you!

I'd be happy to host it under either my personal or company github account but I am also happy for you to own it, given your current active interest in it.

I'd be happy with you to own it- better knowledge of the codebase and probably also the better go coder. What I'd really appreciate though is a discussion about how to solve things if I come up with issues. Seems that's what we're already doing?

In that sense- keep this repo as-is or is there really any need to transfer?

@andig
Copy link
Contributor Author

andig commented Aug 22, 2019

In that sense- keep this repo as-is or is there really any need to transfer?

Hi @jonseymour no problem should you have changed your mind in the meantime- would appreciate a hint if I really should go for hard fork?

@andig
Copy link
Contributor Author

andig commented Sep 20, 2019

For the record, I'm starting a hard fork at https://github.com/andig/gosunspec. Thanks for your efforts.

@crabmusket
Copy link
Owner

Best of luck @andig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants