Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Rector php 8.0 set #16711

Open
wants to merge 8 commits into
base: 5.x
Choose a base branch
from
Open

Enable Rector php 8.0 set #16711

wants to merge 8 commits into from

Conversation

samsonasik
Copy link
Contributor

@samsonasik samsonasik commented Feb 16, 2025 •
edited
Loading

Description

Applied changes:

  • use str_contains/str_starts_with/str_ends_with
  • use static::class over get_class($this)
  • remove unused variable cactch on try catch
  • use $object::class over get_class($object)
  • apply constructor promotion
  • make implements \Stringable with __toString() method class.

Related issues

@samsonasik samsonasik force-pushed the rector-enable-php80 branch 2 times, most recently from d262f20 to ac0eb0a Compare February 16, 2025 09:18
@samsonasik
Copy link
Contributor Author

Ready to merge 👍

@samsonasik
Copy link
Contributor Author

@brandonkelly Ready to merge 👍

@samsonasik
Copy link
Contributor Author

@brandonkelly Ready to merge 👍

brandonkelly
brandonkelly reviewed Feb 20, 2025
View reviewed changes
@samsonasik
Copy link
Contributor Author

@brandonkelly Ready to merge 👍

@samsonasik
Copy link
Contributor Author

@brandonkelly Ready to merge 👍

brandonkelly
brandonkelly reviewed Feb 25, 2025
View reviewed changes
src/cache/ElementQueryTagDependency.php
/**
* Constructor
*
* @param ElementQuery $elementQuery
* @param array $config
*/
public function __construct(ElementQuery $elementQuery, array $config = [])
public function __construct(public ?ElementQuery $elementQuery, array $config = [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the signature. null was previously not allowed to be passed to $elementQuery.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The promotion property is based on property type, so you choose: to have nullable or non-nullable property?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonkelly brandonkelly brandonkelly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @brandonkelly