Merge pull request #3892 from craftcms/feature/rector-73

rector using the php 7.3 ruleset

Author: angrybrad

rector.php

@@ -9,4 +9,4 @@
         __DIR__ . '/src',
         __DIR__ . '/tests/unit',
     ])
-    ->withPhpSets(php70: true);
+    ->withPhpSets(php73: true);

src/services/Formulas.php

@@ -142,7 +142,7 @@ public function evaluateFormula(string $formula, array $params, ?string $setType
     private function _hasDisallowedStrings(string $code, array $disallowedStrings = []): bool
     {
         foreach ($disallowedStrings as $disallowedString) {
-            if (stripos($code, $disallowedString) !== false) {
+            if (stripos($code, (string) $disallowedString) !== false) {
                 return true;
             }
         }

tests/unit/elements/variant/VariantQueryTest.php

@@ -130,7 +130,7 @@ public function testShippingCategory(): void
             'non-matching-shipping-category' => [$nonMatchingShippingCategory, 0],
         ];
 
-        foreach ($tests as $key => list($criteria, $count)) {
+        foreach ($tests as $key => [$criteria, $count]) {
             $query = Variant::find();
             $query->shippingCategory($criteria);