Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Image not working #39

Open
stephenheron opened this issue Jul 1, 2024 · 2 comments
Open

Edit Image not working #39

stephenheron opened this issue Jul 1, 2024 · 2 comments

Comments

@stephenheron
Copy link

Description

Hi,

We have installed the Google Cloud Plugin, a user noticed an issue when using the 'Edit Image' functionality.

When performing a rotate or crop, the thumbnails don't get generated with the newly updated image.

We did some investigation, and we think it is related to the cache behaviour of GCP (https://cloud.google.com/storage/docs/consistency#cache-control). We observed that the code generating the thumbnails was operating on a version of the image that wasn't the most recently edited version.

We dropped the 'Cache Duration' setting down to 1 second and added a sleep of 10 seconds in the AssetsController, and then the thumbnails generated, after the image was edited, were correct.

We also tested a local filesystem to make sure there wasn't some issue with our Craft installation and the image editing functionality worked as expected.

Steps to reproduce

  1. Install Google Cloud Plugin
  2. Create new Cloud Storage Filesystem with cache duration of 30days.
  3. Make a new volume with the previously created filesystem.
  4. Upload image to new volume
  5. Edit image and rotate vertically
  6. Thumbnails will not be updated
Copy link

linear bot commented Jul 1, 2024

@stephenheron
Copy link
Author

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant