Review marshalling of Decimal values

[amotl]

About

Based on a comment by @seut,

I think using a float won't work as a Decimal has a 128bit range and thus cannot fit into a float.

• Types: Adjust CrateJsonEncoder to cast Decimal values to Python float types crate/crate-python#604 (comment)

this piece of code may want to be reviewed.

meltano-target-cratedb/target_cratedb/sqlalchemy/patch.py

Lines 54 to 68 in 2b20640

	def patch_json_encoder():
	"""
	`Decimal` types have been rendered as strings.
	TODO: Upstream to crate-python.
	"""
	json_encoder_default = CrateJsonEncoder.default
	def default(self, o):
	if isinstance(o, Decimal):
	return float(o)
	return json_encoder_default(o)
	CrateJsonEncoder.default = default

References

• Data Type: NUMERIC crate/crate-python#652
• Types: Add method ObjectArray.as_generic crate/sqlalchemy-cratedb#23
• Types: Improve type mappings crate/sqlalchemy-cratedb#24