Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Rename handbook to admin again #15

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 20, 2024

Why?

The label fits better to the content, and it actually has been the label used previously.

Preview

https://cratedb-guide--15.org.readthedocs.build/
https://cratedb-guide--15.org.readthedocs.build/admin/

@amotl

This comment was marked as resolved.

The label fits better to the content, and it actually has been the label
used previously.
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm otherwise.

Comment on lines -1 to -3
.. _handbook:
.. _handbooks:
.. _user-handbooks:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double checking: We do not reference this anywhere under these names already, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, because I've just introduced that recently. Otherwise, referenced projects will tell us on CI.

@amotl amotl merged commit 8f14c93 into main Feb 21, 2024
3 checks passed
@amotl amotl deleted the amo/rename-handbook branch February 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants