Added import job documentation #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpardo
requested review from
plaharanne,
tomach,
WalBeh,
Taliik and
SStorm
as code owners
SStorm
approved these changes
Sep 29, 2023
| @@ -305,10 +305,9 @@ def import_jobs_list(args: Namespace) -> None: | |||
| print_response( | |||
| data=data, | |||
| errors=errors, | |||
| keys=["id", "cluster_id", "status", "type", "url", "destination"], | |||
There was a problem hiding this comment.
Maybe worth replacing url with source?
SStorm
approved these changes
Oct 2, 2023
croud/printer.py
Outdated
| @@ -158,14 +158,27 @@ def format_rows(self, rows: Union[List[JsonDict], JsonDict]) -> str: | |||
| # | bar | 2 | | |||
| # +-----+-----+ | |||
|
|
|||
| headers = list(map(str, rows[0].keys())) if len(rows) else self.keys | |||
| # all_keys = [row.keys() for row in rows] | |||
There was a problem hiding this comment.
We probably don't need the comments?
juanpardo
force-pushed
the
jp/import-job-documentation
branch
from
acaed39
to
561a83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
import-job create from-urlthrowing an error despite working.Checklist