Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EmployeeList for clarity and performance #99

Open
crawfoal opened this issue Sep 19, 2016 · 0 comments
Open

Refactor EmployeeList for clarity and performance #99

crawfoal opened this issue Sep 19, 2016 · 0 comments

Comments

@crawfoal
Copy link
Owner

See if we can make it more clear what we're doing - the goal is simply to get a list of all employees at a particular gym, where each user is listed once, and all of their roles at that gym are listed.

Ideally this refactor would also improve performance, and we'd be able to remove the following bullet n+1 query whitelists:

  • User => :roles
  • User => :manager_story
  • User => :setter_story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant