Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit additional step to the readme #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpmi-13
Copy link

@lpmi-13 lpmi-13 commented Jul 5, 2023

This was easy to miss during the process of setting up the action, and it would have been nice for it to be more explicit when we were setting this up.

@lpmi-13 lpmi-13 requested a review from crazy-max as a code owner July 5, 2023 21:31
@crazy-max
Copy link
Owner

This is just to set up a GPG key on GitHub but this is not a prerequisite. It can also be different following the provider (GitHub, Gitlab, ...). Maybe we can add a "Note" section in the readme to set this up for GitHub.

@lpmi-13
Copy link
Author

lpmi-13 commented Aug 1, 2023

Sounds good...I'll amend this PR when I'm back from vacay (next week)

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to set up a GPG key on GitHub but this is not a prerequisite. It can also be different following the provider (GitHub, Gitlab, ...). Maybe we can add a "Note" section in the readme to set this up for GitHub.

^

@lpmi-13
Copy link
Author

lpmi-13 commented Sep 13, 2023

hey there, sorry about forgetting to come back to this. Now updated to be in a separate Notes section instead of as a prerequisite.

@lpmi-13 lpmi-13 requested a review from crazy-max September 13, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants