add --with-frankenphp-app option to embed an app

Author: henderkes

src/SPC/builder/unix/UnixBuilderBase.php

@@ -16,6 +16,7 @@
 use SPC\toolchain\GccNativeToolchain;
 use SPC\toolchain\ToolchainManager;
 use SPC\util\DependencyUtil;
+use SPC\util\GlobalEnvManager;
 use SPC\util\SPCConfigUtil;
 use SPC\util\SPCTarget;
 
@@ -134,8 +135,8 @@ protected function sanityCheck(int $build_target): void
         if (($build_target & BUILD_TARGET_EMBED) === BUILD_TARGET_EMBED) {
             logger()->info('running embed sanity check');
             $sample_file_path = SOURCE_PATH . '/embed-test';
-            if (!is_dir($sample_file_path) && !mkdir($sample_file_path) && !is_dir($sample_file_path)) {
-                throw new SPCInternalException("Failed to create directory: {$sample_file_path}");
+            if (!is_dir($sample_file_path)) {
+                @mkdir($sample_file_path);
             }
             // copy embed test files
             copy(ROOT_DIR . '/src/globals/common-tests/embed.c', $sample_file_path . '/embed.c');
@@ -267,8 +268,6 @@ protected function patchPhpScripts(): void
     /**
      * Process the --with-frankenphp-app option
      * Creates app.tar and app.checksum in source/frankenphp directory
-     *
-     * @return bool True if the app.tar was created successfully, false otherwise
      */
     protected function processFrankenphpApp(): void
     {
@@ -313,11 +312,11 @@ protected function getFrankenPHPVersion(): string
 
     protected function buildFrankenphp(): void
     {
+        GlobalEnvManager::addPathIfNotExists(GoXcaddy::getEnvironment()['PATH']);
         $this->processFrankenphpApp();
         $nobrotli = $this->getLib('brotli') === null ? ',nobrotli' : '';
         $nowatcher = $this->getLib('watcher') === null ? ',nowatcher' : '';
         $xcaddyModules = getenv('SPC_CMD_VAR_FRANKENPHP_XCADDY_MODULES');
-        // Check if we have a custom app.tar in source/frankenphp
         $frankenphpSourceDir = SOURCE_PATH . '/frankenphp';
 
         $xcaddyModules = preg_replace('#--with github.com/dunglas/frankenphp(=\S+)?#', '', $xcaddyModules);