-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disclaimer on the skill filter in the issue finder #518
Comments
Hey @dhruvkb , I think switching to a system where we have to assign a skill to each issue might be a good choice in the long run but it will take time to switch over and it would have to be very well documented and prominent in the docs. Therefore, I believe that a short term fix might be to simply document this behavior. Then, we can open up a new issue and work towards a more permanent/long-term fix. How does that sound? P.S. : This is my first issue here 😁 |
Yes, we should document this for now. |
Great, should I go ahead and do that? |
Hi @dhruvkb, can I work on this? |
@c99SRS in #527, @CodeSarthak has already made a PR to fix this, but I've added some pointers for improvement to that. Could you open a PR with only the suggested changes (so that I can merge both independently)? |
HI @dhruvkb , Could you please tell any specific UI for this or is there any particular section we have to make the change? |
How about we add an asterisk |
Yes. we can try out that one. |
HI @dhruvkb , please take a look, made some changes. Attached the screenshot. |
Hey @dhruvkb , I am raising one PR, if you are ok with this. |
Hi @dhruvkb , could you please merge my PR? |
@c99SRS I'll review and merge it soon. You can continue to work on other issues in the meantime! |
Description
Not all issues have skills marked on them, especially if they are simple issues that do not require proficiency in any specific framework or language. Those issues are gone when filtering by skill in the Issue Finder. This behaviour should be explained to the user on the page.
Reproduction
Expectation
This anomalous behaviour should be well documented.
Alternatives
Alternatively, we can collectively decide that every issue should have a skill, regardless of the level of proficiency of said skill required to resolve the issue (might tie into creativecommons/ccos-scripts#86).
Resolution
The text was updated successfully, but these errors were encountered: