Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal styling to correct the mobile menu to meet design system requirement #219

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dev-JoyA
Copy link
Contributor

@Dev-JoyA Dev-JoyA commented Oct 14, 2024

Fixes

Description

This PR corrects the mobile menu on the LegalDB website to align with the current Vocabulary design system. Changes the hamburger icon to use a "Menu" button.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dev-JoyA Dev-JoyA requested review from a team as code owners October 14, 2024 10:36
@Dev-JoyA Dev-JoyA requested review from TimidRobot, Shafiya-Heena and krysal and removed request for a team October 14, 2024 10:36
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! This PR already has the functionality, but it needs some styling work.

  1. Narrow - Menu button
    • Screenshot 2024-10-14 at 07-41-31 CC Legal Database
  2. Wide - full menu
    • Screenshot 2024-10-14 at 07-41-18 CC Legal Database
  3. Less wide - "light" Menu link
    • Screenshot 2024-10-14 at 07-41-23 CC Legal Database
    • This third state doesn't exist in the current code and should be removed
      Also note code comments

webpack/sass/styles.scss Outdated Show resolved Hide resolved
legal_db/templates/legal_db/partials/_header.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/partials/_header.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/partials/_header.html Outdated Show resolved Hide resolved
legal_db/templates/legal_db/partials/_header.html Outdated Show resolved Hide resolved
@TimidRobot TimidRobot changed the title Used internal styling to correct the mobile menu to meet design syste… Use internal styling to correct the mobile menu to meet design system requirement Oct 14, 2024
@Dev-JoyA
Copy link
Contributor Author

@TimidRobot
Screenshot 2024-10-15 at 09 07 38
This is the mobile menu, light menu link removed

@TimidRobot TimidRobot self-assigned this Oct 16, 2024
@TimidRobot TimidRobot added the 🚧 status: blocked Blocked & therefore, not ready for work label Oct 16, 2024
@TimidRobot
Copy link
Member

@Dev-JoyA
Copy link
Contributor Author

@TimidRobot I have synced the branch with changes from main, but I cant seem to request for a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Mobile Menu on LegalDB website doesn't match the current Vocabulary design system
2 participants