Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Reconsider inclusion/function of Jamendo, terms and filtering are misaligned #216

Open
1 task
possumbilities opened this issue Aug 18, 2023 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🏷 status: label work required Needs proper labelling before it can be worked on 🧹 status: ticket work required Needs more details before it can be worked on 💬 talk: discussion Open for discussions and feedback

Comments

@possumbilities
Copy link
Contributor

possumbilities commented Aug 18, 2023

Description

Originally posted by @heyakyra in #124 (comment)

Also, the search returns the "invalid search result: https://www.jamendo.com/search?q=fq" because of the malformed search query.

The malformed query may be due to the fact that the Jamendo site may have been updated and their search query format updated as well, implying that we may need to update ours in return so as to get expected results.

The current state is broken still, and results in queries like so, where the search terms become [query-nc] [-nd] instead of [query] [-nc] [-nd]:

Screenshot 2023-08-18 at 10-15-33 CC Search Portal
Screenshot from 2023-08-18 10-14-54

And either way, the filters for removing noncommercial and non-derivative licensed results don't work.

So as it stands, the old Jamendo contains music that can be modified, downloaded, and reused (Personal use).

And the site licensing.jamendo contains music that can be used for commercial purposes and played in public places.

[…] So for example, if the user checked the "use for commercial purposes" checkbox, we redirect to licensing.jamendo else we redirect to old Jamendo

This is incorrect, and therefore the solution implemented in #137 is backwards. Jamendo has adopted the language of the music industry oligopoly: "can be used commercially" actually means you can't use it commercially until you buy a license. "can be used personally" means you can use it personally (and maybe commercially too, but it's not in our financial interest to inform you)

Resolution

  • I would be interested in resolving this bug.
@possumbilities possumbilities added 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 💬 talk: discussion Open for discussions and feedback 🏷 status: label work required Needs proper labelling before it can be worked on 🧹 status: ticket work required Needs more details before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Aug 18, 2023
@heyakyra
Copy link

heyakyra commented Aug 18, 2023

Thank you! The only way to filter by license is using their API which users can do through Openverse instead of the official website: WordPress/openverse#1319 (comment)

@cc-open-source-bot cc-open-source-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Aug 19, 2023
@possumbilities possumbilities removed the 🏷 status: label work required Needs proper labelling before it can be worked on label Sep 18, 2024
@cc-open-source-bot cc-open-source-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🏷 status: label work required Needs proper labelling before it can be worked on 🧹 status: ticket work required Needs more details before it can be worked on 💬 talk: discussion Open for discussions and feedback
Projects
Status: Backlog
Development

No branches or pull requests

3 participants