Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Change button text when active or inactive. #89

Open
1 task done
SisiVero opened this issue Oct 4, 2024 · 5 comments · May be fixed by #145 or #162
Open
1 task done

[Feature] Change button text when active or inactive. #89

SisiVero opened this issue Oct 4, 2024 · 5 comments · May be fixed by #145 or #162
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@SisiVero
Copy link

SisiVero commented Oct 4, 2024

Problem

Currently, when a user clicks on the view button, only the background changes.

Proposed feature:
A change in text would also be great and enhance UX. When a user clicks on the view button, the background changes, the text as well should change to "close". This will enhance user experience.
activeViewBTn
InactiveViewBtn

  • I would be interested in implementing this feature.
@SisiVero SisiVero added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 4, 2024
@SisiVero
Copy link
Author

SisiVero commented Oct 4, 2024

Also notice the images are broken. I already opened an issue for it. I believe when the images display, then we will get to know if the break in interface occurring will still occur.

@meljaszuk
Copy link

meljaszuk commented Oct 4, 2024 •
edited
Loading

Please assign to me! Thank you @SisiVero

@possumbilities
Copy link
Contributor

changing the text here should likely be done within the vocabulary.js file in the section controlling open/close behavior.

@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 7, 2024
@SisiVero SisiVero linked a pull request Oct 8, 2024 that will close this issue
Open
5 tasks
@SisiVero
Copy link
Author

SisiVero commented Oct 8, 2024

Yes @possumbilities that's where it will be done or I did it.
I updated the existing functionality for the button

@Immy-delish
Copy link

I am glad you noticed this issue😊. I noticed it too.

@Immy-delish Immy-delish linked a pull request Oct 10, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
WebDev
Status: Backlog
Milestone
No milestone
4 participants
@Immy-delish @SisiVero @possumbilities @meljaszuk