Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Typos in CSS Class and Variable Names #260

Open
1 task done
shivam8112005 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #263 or #266
Open
1 task done

[Bug] Typos in CSS Class and Variable Names #260

shivam8112005 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #263 or #266
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work

Comments

@shivam8112005
Copy link
Contributor

Description

There are typos in the CSS code of library-vars.css file, including misspelled class names and variables, which result in incorrect icon rendering. For example, fa-angle-right is misspelled as fa-angle-rignt here:

vocabulary/src/css/library-vars.css

Line 204 in 746a0de

.icon.fa-angle-right, .icon-attach.fa-angle-rignt:before {

also here:

vocabulary/src/css/library-vars.css

Line 224 in 746a0de

.icon.fa-right-angle, .icon-attach.fa-righ-angle:before {

on line 224 class is named fa-right-angle It should'nt be like fa-angle-right.

Reproduction

  1. In the .icon.fa-angle-right rule, the class name is incorrectly written as .fa-angle-rignt instead of .fa-angle-right.
  2. In the .icon.fa-right-angle rule, the variable --fa-heart is mistakenly used for the sprite, but it should be --fa-right-angle.
  3. See errors.

Expectation

The icons should render correctly when using the specified classes when we use it.

Screenshots

Environment

  • Device: laptop
  • OS: Windows 11
  • Browser: Chrome
  • Version: 117
  • Other info: 1920x1080

Additional context

The incorrect spelling of class names and variable assignments in the CSS file can cause rendering issues.

Resolution

  • I would be interested in resolving this bug.
@shivam8112005 shivam8112005 added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Oct 18, 2024
@possumbilities possumbilities added 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work and removed 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 18, 2024
@Immy-delish Immy-delish linked a pull request Oct 18, 2024 that will close this issue
Open
7 tasks
@shivam8112005 shivam8112005 linked a pull request Oct 19, 2024 that will close this issue
Open
7 tasks
@jessyovia jessyovia mentioned this issue Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work
Projects
WebDev
Status: Backlog
Milestone
No milestone
2 participants
@possumbilities @shivam8112005