Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scroll-to-top feature #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Daodu111
Copy link

Fixes

Description

I created a scroll-to-top feature that uses only HTML and CSS and follows the instructions of using pseudeoelements to solve the issue.

Technical details

It uses only HTML and CSS

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Daodu111 Daodu111 requested review from a team as code owners October 10, 2024 13:24
@Daodu111 Daodu111 requested review from TimidRobot, possumbilities and nimishbongale and removed request for a team October 10, 2024 13:25
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit b0721f3
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6707d5adab49880008b49359
😎 Deploy Preview https://deploy-preview-165--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -1 +1,3 @@
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to this file should be removed they're not a part of this repo

@possumbilities
Copy link
Contributor

Hi! @Daodu111 This is a lot of good work, and the start of a very good direction!

The visual styling of this button is really nice, however we don't utilizing drop shadows in other instances and the use of it here is a bit of a UX collision. Additionally the choice of color is too attention-seeking the neutral grey would be a better direction.

It's placement is too far to the right, and too close to the bottom of the window. It should likely appear once the page has reached a great height, and well after any sidebar area of content might occur; and likely be positioned somewhere closer to the middle of the sidebar area's location.

The button also needs to be an element that could occur within the HTML of every page, but only become visible on longer pages. Please see the original Issue on the mention of pseudo classes to obscure the element.

CSS pseudo elements using z-index stack positions and variable percentage based heights would offer a means to "reveal" the button after a degree of scrolling, and to visually hide the element on pages which do not reach a particular length.

(you'll also need to resolve the current conflicts with the PR as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Add a scroll-to-top element to UX for longer page contexts
3 participants