Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made design system ui mobile responsive #82

Conversation

OmarAmeen01
Copy link
Contributor

@OmarAmeen01 OmarAmeen01 commented Oct 4, 2024

[WIP] [Bug] Mobile responsibility UI issue

Fixes

  • reduced font size of h1 tag to 2.6 rem on larger devices and 1.6rem on smaller devices

  • Gave padding of 1rem on the left and right side to almost all elements

  • Added a :root configuration were i mentioned box -sizing to border box at the top of vocabulary.css so that the padding and margin given to element remain restricted to the element and won't cause any abnormalities in the ui

  • Adjusted styling of a.more gave it a margin of 1rem

  • Added new style class body span and gave it a padding of 1rem

  • Adjusting the styling of article.Related post ul >li they were causing footer to shrink more as the were not wrapping when screen sized reduces Made a griid template column appropriate to the size of window for them so they can adjust with the screen size

  • Removed the width of 100% on h2, .posts .post h2, .posts .post h3 they were causing overflow on the body shrinking other elements

  • .blog-index main article.posts.featured > ul li:nth-child(1), .blog-index main .posts.featured ul li:nth-of-type(1) article.post
    on these class I Commented padding for device below the width of 705px because it was causing overflow on blog index index page

on .person-page main > header h1 I Added padding of 1rem to it

Description

Recent changes improved the page's responsiveness by adjusting the font size of h1 for different screen sizes, adding consistent padding, and applying global box-sizing. The layout was enhanced by modifying related post styling to prevent footer shrinking, removing width settings on certain headers to avoid overflow, and addressing padding inconsistencies for smaller screens.

This PR fixes

  • home-index page.html
  • default-page.html
  • blog-post.html
  • blog-index.html

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow [best practices][best practices].
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit af69d0c
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/66fffb09b063140008ee9fb3
😎 Deploy Preview https://deploy-preview-82--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OmarAmeen01 OmarAmeen01 marked this pull request as ready for review October 4, 2024 14:52
@OmarAmeen01 OmarAmeen01 requested review from a team as code owners October 4, 2024 14:52
@OmarAmeen01 OmarAmeen01 requested review from TimidRobot, possumbilities and nimishbongale and removed request for a team October 4, 2024 14:52
@OmarAmeen01 OmarAmeen01 changed the title added padding to the main element so that content won't stick to the wall of window Make design system ui mobile responsive Oct 4, 2024
@OmarAmeen01 OmarAmeen01 changed the title Make design system ui mobile responsive Made design system ui mobile responsive Oct 4, 2024
@possumbilities
Copy link
Contributor

@OmarAmeen01 This PR goes well beyond the scope of the one Issue linked here.

There also seems to be work related to the program-page and Issue #110 which seems to largely be centered around the "Recent Posts" section overflowing the content on that page. There are a myriad of changes made here that are out of scope of that Issue.

PRs should be directly about addressing a specific Issue or Issues. If there are items not yet documented I would urge you to create Issues outlining those items instead.

Closing this PR for now, feel free to submit a PR with a more narrow and targeted scope.

@possumbilities possumbilities self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Mobile responsibility UI issue on default-page.html
2 participants