Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SNIP implementation with broad integration of pybaselines #12

Open
gchure opened this issue Jan 23, 2024 · 0 comments
Open

Replace SNIP implementation with broad integration of pybaselines #12

gchure opened this issue Jan 23, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gchure
Copy link
Member

gchure commented Jan 23, 2024

I've developed hplc-py using only one baseline estimation algorithm (SNIP), but there are many options that can be used. These are nicely tested and developed in the pybaselines package. A development goal of hplc-py would be to deprecate the correct_baseline method of a Chromatogram with a call to the broad pybaselines API.

@gchure gchure added enhancement New feature or request help wanted Extra attention is needed labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant