Assign point size without deprecation notice #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strlen` with a `null` argument triggers a deprecation notice from PHP 8.1; this change ensures that doesn't happen anymore.
|
@djlambert Hi 😊 I realize you haven't updated this library in over 5 years, yet it is still installed over 1500 times per day currently (https://packagist.org/packages/creof/wkb-parser/stats). I don't think there's any major functionality missing, but I reckon it might be good to keep up to date with the latest PHP developments. What is your opinion on that? |
|
I've seen this is now fixed in #23 and released with v2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strlenwith anullargument triggers a deprecation notice from PHP 8.1; this change ensures that doesn't happen anymore.