Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe the simple service should use CUDA images as base too? #224

Open
veritas9872 opened this issue Jan 12, 2025 · 7 comments
Open

Maybe the simple service should use CUDA images as base too? #224

veritas9872 opened this issue Jan 12, 2025 · 7 comments

Comments

@veritas9872
Copy link
Collaborator

A lot of libraries need to compile stuff during runtime. Using an Ubuntu base image is needlessly complicated.

@veritas9872
Copy link
Collaborator Author

But then, how would simple be any different from train?

@veritas9872
Copy link
Collaborator Author

After taking a look at the train image, I think I should just get rid of the fetch-torch option and force that image to always be a version that builds PyTorch. I will make the simple service the default to make life easier.
For this, the simple service needs to be able to take in more base images.

@veritas9872
Copy link
Collaborator Author

Also, I should probably rename the train service to compile or something and make it non-default.

@veritas9872
Copy link
Collaborator Author

Maybe custom?

@veritas9872
Copy link
Collaborator Author

veritas9872 commented Jan 15, 2025

This would also involve totally rewriting the README, which is a lot of work...

@veritas9872
Copy link
Collaborator Author

Also, the simple service can get rid of the frozen conda requirements, I think. I don't use it and no one has asked about it after I removed the frozen environment file.

@veritas9872
Copy link
Collaborator Author

veritas9872 commented Jan 15, 2025

Also, the README is getting a bit embarrassing after all these years. Maybe make it more sober? Although it might be better staying rather colorful. It should most definitely be shorter, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant