Potential fix for code scanning alert no. 26: Incomplete URL substring sanitization #3866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/crewAIInc/crewAI/security/code-scanning/26
To fix this problem, the code should parse the endpoint string as a URL and then check whether the parsed host (netloc) matches the expected domain. Instead of doing a substring test, it should extract the actual host (using
urllib.parse.urlparse) and check if it is exactlyopenai.azure.comor ends with.openai.azure.com. This approach prevents attacker-controlled endpoints with hosts likemalicious.openai.azure.com.evil.comfrom being accepted. The fix should importurlparsefromurllib.parseif not already present, parseself.endpoint, and use the parsed hostname in the comparison. All changes should be localized within the shown code region inlib/crewai/src/crewai/llms/providers/azure/completion.py.Suggested fixes powered by Copilot Autofix. Review carefully before merging.