-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems running the populator #62
Comments
|
Should we remove the possibility to execute the individual implementations directly ? ie remove the Also, this example in the README fails with a validation error. |
Exactly the error I was expecting.
The implementations fail to correctly apply
I'd rather not. There's no technical reason to limit this. |
This command is broken as has been since before my recent updates. The configuration file should be passed with the The README is wrong and should be updated.
Yes this is a bug, the debug flag only applies to the logger which is only initialized when run through the CLI. I am already working on code cleanup that will fix this.
This is because the current script is already called "logging.py" and that clobbers the builtin "logging" module in the namespace when imported directly. This is fixed in code cleanup work that is in progress (see above).
Are you talking about the discussion here? #60 (comment)
That's one option... or we could stick with a single interface to run the populators:
Yes! Everything should go through one interface:
Technical reasons:
|
I also fear trying to support two entry points would make a mess. |
To explain this further, here is a minimal concrete example that demonstrates that the issue is due to conflicting module names: All of the following commands produce the error
So you can see that adding an
|
I agree about making As for the logging issue, I'm guessing |
Running the command found in the README
fails with
If I try to run this without the collection path, I get:
If I try to run
cli.py
directly, I getThe text was updated successfully, but these errors were encountered: