Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify slicer.py by using Python ffmpeg bindings #68

Open
3 tasks
audreyfeldroy opened this issue Oct 7, 2023 · 8 comments
Open
3 tasks

Simplify slicer.py by using Python ffmpeg bindings #68

audreyfeldroy opened this issue Oct 7, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest-accepted Issue or PR is approved for anyone who wants it to count toward Hacktoberfest help wanted Extra attention is needed

Comments

@audreyfeldroy
Copy link
Member

  • Look into if https://github.com/kkroening/ffmpeg-python has Python code similar to slicer.py
  • Check if there are other similar Python ffmpeg bindings
  • If so, refactor slicer.py to reduce our lines of code by using any Python ffmpeg bindings as a dependency
@audreyfeldroy audreyfeldroy added good first issue Good for newcomers hacktoberfest-accepted Issue or PR is approved for anyone who wants it to count toward Hacktoberfest help wanted Extra attention is needed labels Oct 7, 2023
@heymanpreet
Copy link
Contributor

@audreyfeldroy I can have a look at it if not started by anyone?
Thanks.

@audreyfeldroy
Copy link
Member Author

Great, I assigned this to you, thanks!

@audreyfeldroy
Copy link
Member Author

@heymanpreet I realize there may be some overlap and large merge conflicts with what @RalphHuber started on yesterday with #62. Please wait until he is finished with his pull request. Or pair program together on determining what would be best for the slicer code 🙂

@heymanpreet
Copy link
Contributor

@audreyfeldroy No worries, I will wait until @RalphHuber is done. Thanks for letting me know.🙂

@RalphHuber
Copy link
Collaborator

Cheers @heymanpreet , sorry, will have a PR up for it today, have hopefully separated things out a little bit so it'll be easier to replace pydub if necessary

@heymanpreet
Copy link
Contributor

Thanks, No rush @RalphHuber, let me know when its done. 🙂

@audreyfeldroy
Copy link
Member Author

We're done with our exploration of #72 and you have the go ahead to start exploring here @heymanpreet if you'd like 😊

@heymanpreet
Copy link
Contributor

Cool, Thanks for the update @audreyfeldroy, I will resume work on the issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest-accepted Issue or PR is approved for anyone who wants it to count toward Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants