Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic locode coordinate format #9

Closed
alexandrulesi opened this issue Oct 21, 2024 · 3 comments
Closed

Deterministic locode coordinate format #9

alexandrulesi opened this issue Oct 21, 2024 · 3 comments

Comments

@alexandrulesi
Copy link

Hi folks,

following up on the suggestion on this issue on the datahub.io locodes repo I'm opening this ticket here.

@cristan
Right now, my project just has way more and much more accurate coordinates: they are still in 2 different formats.

But that's quite easy to remedy on my side. If you want that, create an issue on my project. What would you like? A new column with all in the un/locode format? A new column with all entries in the decimal format?

We're using the above mentioned repo to source locodes and are facing the issue that the coordinates come in different formats and not just the one mentioned in their documentation. We'd ideally like to use a dataset where all entries are in the same format or at least the formats are distinguished.

So yes your suggestion sounds good. What would be even cooler, though optional, is if you added a conversion step on your side so that both new columns are fully populated. Then we wouldn't need to do conversion on our end every time we pull the dataset.

Thanks for the offer :)

@alexandrulesi alexandrulesi changed the title Deterministic locode format Deterministic locode coordinate format Oct 21, 2024
@cristan
Copy link
Owner

cristan commented Oct 23, 2024

Created the CoordinatesDecimal column. I'll think about what to do with the UN/LOCODE format: make all coordinates in the Coordinates column the UN/LOCODE degrees format, or add another column dedicated for this.

@cristan
Copy link
Owner

cristan commented Oct 25, 2024

Done. The Coordinates column now everywhere has the UN/LOCODE flavour of the degrees notation and there's now also a CoordinatesDecimal column with decimal coordinates.

@cristan cristan closed this as completed Oct 25, 2024
@alexandrulesi
Copy link
Author

Thanks @cristan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants