Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Help package tokens do not work for VM installations (v10+) #313

Closed
m-s- opened this issue Jun 7, 2023 · 5 comments
Closed

UI/Help package tokens do not work for VM installations (v10+) #313

m-s- opened this issue Jun 7, 2023 · 5 comments
Labels
bug Something isn't working workaround available

Comments

@m-s-
Copy link
Collaborator

m-s- commented Jun 7, 2023

CLI will place environment specific tokens in config.json, index.html and ngsw.json that should be replaced by DF when installing the package.
However, the tokens supported by the container entrypoints and the traditional DF installation are not compatible, causing the package to install with tagging in VMs and the UIs to not work anymore.

@m-s-
Copy link
Collaborator Author

m-s- commented Jun 7, 2023

We are exploring if this can be fixed in the DF side or if we need to add a (temporary) feature to the CLI to support both scenarios. However, this will break one of the principles of the packages, being agnostic to installation target.

@m-s-
Copy link
Collaborator Author

m-s- commented Jun 7, 2023

A work around would be to edit the generated package and replacing the tokens with ones supported by the traditional installation process:

config.json

$(TENANT_NAME) -> $(Product.Tenant.Name)
$(APPLICATION_PUBLIC_HTTP_TLS_ENABLED) -> $(Product.ApplicationServer.EnableSsl)
$(APPLICATION_PUBLIC_HTTP_ADDRESS) -> $(Product.ApplicationServer.Address)
$(APPLICATION_PUBLIC_HTTP_PORT) -> $(Product.ApplicationServer.Port)
$(SYSTEM_NAME) -> $(Product.SystemName)
"$(SECURITY_PORTAL_STRATEGY_LOCAL_AD_DEFAULT_DOMAIN) -> $(Product.Security.Domain)

index.html and ngsw.json

replace $(APPLICATION_BASE_HREF) with /

@m-s- m-s- added bug Something isn't working workaround available labels Jun 7, 2023
@m-s-
Copy link
Collaborator Author

m-s- commented Jun 7, 2023

This is technically a Deployment Framework bug, not a CLI bug, but I've tagged the issue as such anyway for easier reference.

@socujun
Copy link

socujun commented Jun 8, 2023

Thanks for your guidance, my page can also be displayed, otherwise I will be stuck in the project

@m-s-
Copy link
Collaborator Author

m-s- commented Aug 9, 2023

This is fixed by MES 10.1, in which VM DF understands the container tokens

@m-s- m-s- closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workaround available
Projects
None yet
Development

No branches or pull requests

2 participants