Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the same variable name for PackageId/PackageName on Core project #347

Open
joaoopereira opened this issue Oct 27, 2023 · 0 comments
Open

use the same variable name for PackageId/PackageName on Core project #347

joaoopereira opened this issue Oct 27, 2023 · 0 comments

Comments

@joaoopereira
Copy link
Member

We should use always the same variable name on core project:

cli/core/StartupModule.cs

Line 23 in df7956a

/// <param name="packageName">Package name used for INPMClient implementations</param>

vs

cli/core/Objects/ExecutionContext.cs

Line 50 in df7956a

public static string PackageId => (ServiceProvider.GetService<IVersionService>()!.PackageId) ?? "unknown";

IMO we should use PackageId
@joaoopereira joaoopereira changed the title set an uniform variable name for PackageId/PackageName on ServiceProvider use the same variable name for PackageId/PackageName on Core project Oct 27, 2023
@m-s- m-s- added this to the 5.0 milestone Jun 3, 2024
@m-s- m-s- removed this from the 5.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-s- @joaoopereira