Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add version-flavour-git-hash to apk filename #207

Open
Wikinaut opened this issue Oct 23, 2017 · 3 comments
Open

[Suggestion] Add version-flavour-git-hash to apk filename #207

Wikinaut opened this issue Oct 23, 2017 · 3 comments

Comments

@Wikinaut
Copy link
Contributor

Wikinaut commented Oct 23, 2017

In another project I used this commit

to add detailed apk information to the apk filename.

In case that you also like this, I can prepare and send a pr for cmaps. Pls. let me know if you are interested.

@stephanlindauer
Copy link
Member

not sure i understand this. we currently don't safe apk files (apart from in the play dev console). even for f-droid we just have to tag a new release on github and then they'll build their distributable themselfs.

can you explain what the benefit of this would be?

@Wikinaut
Copy link
Contributor Author

@stephanlindauer just to see the currently installed version in the apk filename when compiling from the source, in other words: to avoid version problems as developer. I just wanted to help you with some piece of (older) working code.

@stephanlindauer
Copy link
Member

as far as i can see it's not something that we would need with the current workflow. wdyt @cbalster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants