concern on multiple thread when hook one API in target process

[tigerking]

Great project. After carefully read the source code and implementation, I have one concern, not sure it is correct. My concern is if the hooked API is called by multiple threads in one process, is it safe?
That is saying if the hooked thread is called and goes into hook_postcall() but not completed, another thread is trying call the same hooked API, how to deal with this case? Thanks
--TK

[jduck]

Your assessment is correct. An entirely different hooking technique is needed to overcome this limitation.

[E3V3A]

And which technique is that?

[jduck]

Right now it uses a hook that is inserted and then temporarily removed to execute the original. What's needed is to relocate the overwritten instructions to some other executable memory and insert a persistent hook. Alternatively, the entire hooked function could be relocated. The main point is that the hook needs to be there the entire time that we wish it to be activated.