Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TicketAuth has option to provide authextra, which is not implemented #561

Open
andzejsw opened this issue Nov 26, 2024 · 3 comments
Open

Comments

@andzejsw
Copy link
Contributor

I want to send authextra during TicketAuth which is also defined for this auth scenario, but when looking deeper it is visible that it is not implemented and server instead receives null value.
This is how class constructor looks:

2024-11-26 174402

And this is how it is implemented in "reallyJoin" method within Session.java class:

Ekrānuzņēmums 2024-11-26 175103

As we can see, authextra always stays null.

@andzejsw
Copy link
Contributor Author

Missing line: authextra = auth.authextra;

@om26er
Copy link
Contributor

om26er commented Nov 26, 2024

@andzejsw I guess this would be a good first contribution. Can you do a PR to fix that?

@andzejsw
Copy link
Contributor Author

@om26er Yes. Now I made it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants