Add support for poll interval and max-reconcile-rate flags #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support for poll interval and max-reconcile-rate flags allowing to the users set a custom configuration. In order to use these flags it is necessary update the controller runtime used from k8s-runtime to crossplane-runtime. Also the starting debug log now prints the new configuration on start up:
2024-01-26T08:24:58+01:00 DEBUG provider-kafka Starting {"sync-period": "1h0m0s", "poll-interval": "1m0s", "max-reconcile-rate": 10}
Fixes #61
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested locally by:
make test
--poll=2m --max-reconcile-rate=1
and checking that 2 topics and 2 ACLs are processed one by one and once they are in a ready status, the reconcile loop happened every 2 min