Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for poll interval and max-reconcile-rate flags #65

Merged

Conversation

mariomalinditex
Copy link
Contributor

Description of your changes

Add support for poll interval and max-reconcile-rate flags allowing to the users set a custom configuration. In order to use these flags it is necessary update the controller runtime used from k8s-runtime to crossplane-runtime. Also the starting debug log now prints the new configuration on start up:

2024-01-26T08:24:58+01:00 DEBUG provider-kafka Starting {"sync-period": "1h0m0s", "poll-interval": "1m0s", "max-reconcile-rate": 10}

Fixes #61

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested locally by:

  • Executing make test
  • Running the provider in a local cluster without any additional configuration and checking that it still working with the default configuration
  • Running the provider with --poll=2m --max-reconcile-rate=1 and checking that 2 topics and 2 ACLs are processed one by one and once they are in a ready status, the reconcile loop happened every 2 min

@mariomalinditex mariomalinditex force-pushed the add-missing-controller-options branch from c51ad9f to 0f469b3 Compare January 26, 2024 08:21
@mariomalinditex
Copy link
Contributor Author

Hi @turkenh,
I am not sure if you were notified of this PR, could you take a look at it?

Thanks :)

@dukanto
Copy link

dukanto commented Apr 30, 2024

Any news about this?
We need it too :)

@malodie malodie merged commit 6bfe34e into crossplane-contrib:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing --poll, --sync, --max-reconcile-rate container arguments
3 participants